[Dart][Jaguar] various improvements #1596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add properties to send or not null values update deps
jaumard
force-pushed
the
feature/update_jaguar_gen
branch
from
779fbae to
5107909
Compare
|
Thanks for the PR. Please update the PR with a description to explain the change and a better title/subject to describe the PR. |
jaumard
changed the title
|
@wing328 done :) |
wing328
reviewed
Dec 4, 2018
...napi-generator/src/main/java/org/openapitools/codegen/languages/DartJaguarClientCodegen.java
Show resolved
Hide resolved
wing328
reviewed
Dec 6, 2018
| @@ -2,12 +2,12 @@ part '{{classFilename}}.jser.dart'; | |||
|
|
|||
| class {{classname}} { | |||
| {{#vars}}{{#description}} /* {{{description}}} */{{/description}} | |||
| @Alias('{{{baseName}}}') | |||
| @Alias('{{baseName}}') | |||
There was a problem hiding this comment.
Minor suggestion: using {{{baseName}}} to avoid escaping HTML special characters.
wing328
changed the title
|
@jaumard thanks for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529. Happy New Year and looking forward to more collaboration and contributions in 2019! |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
add properties to send or not null values update deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dart deps
Add default timeout on http requests
Add nullableField option to send or not null field on the payload