-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[BUG][JAVA] Prevent generating "pattern" and "size" to ENUM #18478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][JAVA] Prevent generating "pattern" and "size" to ENUM #18478
Conversation
Update to 4.2.3
modules/openapi-generator/src/main/java/org/openapitools/codegen/utils/ModelUtils.java
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/java/org/openapitools/codegen/utils/ModelUtils.java
Show resolved
Hide resolved
@jorgerod do you mind filing a new PR with just 1 commit as we prefer cleaner commit history? (19 out of 21 commits in this PR do not seem to be relevant to the change) |
Yes, I will, but haven't you thought about mixing with "squash and merge" instead of "merge"? |
we've been doing that (squash and merge) for years. cleaner commits help everyone and it's something we ask contributors to do recently (and everyone is ok with that so far) |
Deleted in favor of: |
Closes: #18477
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)