Skip to content

[BUG][JAVA] Prevent generating "pattern" and "size" to ENUM #18478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed

[BUG][JAVA] Prevent generating "pattern" and "size" to ENUM #18478

wants to merge 21 commits into from

Conversation

jorgerod
Copy link
Contributor

@jorgerod jorgerod commented Apr 24, 2024

Closes: #18477

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

@jorgerod jorgerod marked this pull request as ready for review April 24, 2024 10:44
@jorgerod jorgerod changed the title Merge pull request #1 from OpenAPITools/master [BUG][JAVA] Prevent generating "pattern" and "size" to ENUM Apr 24, 2024
@jorgerod jorgerod requested a review from wing328 April 25, 2024 07:55
@jorgerod jorgerod requested a review from wing328 May 13, 2024 11:30
@wing328
Copy link
Member

wing328 commented May 13, 2024

@jorgerod do you mind filing a new PR with just 1 commit as we prefer cleaner commit history? (19 out of 21 commits in this PR do not seem to be relevant to the change)

@jorgerod
Copy link
Contributor Author

@jorgerod do you mind filing a new PR with just 1 commit as we prefer cleaner commit history? (19 out of 21 commits in this PR do not seem to be relevant to the change)

Yes, I will, but haven't you thought about mixing with "squash and merge" instead of "merge"?

@wing328
Copy link
Member

wing328 commented May 13, 2024

we've been doing that (squash and merge) for years.

cleaner commits help everyone and it's something we ask contributors to do recently (and everyone is ok with that so far)

@jorgerod jorgerod closed this by deleting the head repository May 13, 2024
@jorgerod
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][JAVA] Prevent generating "pattern" and "size" to ENUM
2 participants