Skip to content

[javascript-closure-angular] Change metadata to reflect beta status and non-existing xml capability in docs #18834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Jun 2, 2024

It says on https://openapi-generator.tech/docs/generators/javascript-closure-angular in the helpTxt that this generator is (beta), however the stability is shown as STABLE.

It also suggests that XML is supported, while the templates clearly show it isn't.

This PR amends that.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Philzen Philzen marked this pull request as ready for review June 2, 2024 17:42
@Philzen Philzen force-pushed the change/fix-javascript-closure-angular-generator-metadata branch from ae514d5 to 8fa9a76 Compare June 4, 2024 14:56
@wing328
Copy link
Member

wing328 commented Jun 5, 2024

in next major release, we may deprecate it as it's no longer actively maintained.

Good to know – now i'm glad i haven't actually looked into the code too much further 😅

@wing328 wing328 merged commit 86f23e1 into OpenAPITools:master Jun 5, 2024
15 checks passed
@wing328 wing328 added this to the 7.7.0 milestone Jun 5, 2024
welshm pushed a commit to welshm/openapi-generator that referenced this pull request Jun 5, 2024
…nd non-existing xml capability in docs (OpenAPITools#18834)

* Fix generator metadata to reflect beta status and non-existing xml capability

* Regenerate doc page

* Regenerate docs/generators.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants