Skip to content

[csharp][generichost] Add options for model parameter sorting #18886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devhl-labs
Copy link
Contributor

@devhl-labs devhl-labs commented Jun 9, 2024

Moves the changes made here #18706 to an option. The plan is to change the sorting method to default when we get to 8.0 with the samples using alphabetical sorting. Some of the samples were changed to alphabetical now because there is a model in the petstore that does not work with legacy.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

devhl-labs and others added 15 commits June 1, 2024 17:46
improved apiclient.mustache to keep it dry, sharing a single exec with Action<> delegate.
improved api.mustache to keep it dry, used chain constructors, kept RequestOptions in a single method, set configuration with alias directive
moved fqn types to using directive for cleaner code
removed 'this' from variables/props that are redundant
fix CSharpClientDeepObjectTest code is now DRY so count must only be one
@devhl-labs devhl-labs changed the title Add options for model parameter sorting [csharp][generichost] Add options for model parameter sorting Jun 9, 2024
@devhl-labs devhl-labs marked this pull request as draft June 10, 2024 23:55
@devhl-labs devhl-labs marked this pull request as ready for review June 11, 2024 00:43
@wing328 wing328 merged commit 3abe251 into OpenAPITools:master Jun 12, 2024
15 checks passed
@wing328 wing328 added this to the 7.7.0 milestone Jun 12, 2024
@devhl-labs devhl-labs deleted the add-options-for-model-parameter-sorting branch June 12, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants