Skip to content

Fix #18715 [JAVA] ensure codegen fields and additionalProperties are not conflicting #18935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jpfinne
Copy link
Contributor

@jpfinne jpfinne commented Jun 14, 2024

Only write back to additionalProperties if it was present

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Jun 16, 2024

can you please resolve the merge conflicts when you've time? then I'll get it merged first thing before merging other PRs

@jpfinne
Copy link
Contributor Author

jpfinne commented Jun 16, 2024

can you please resolve the merge conflicts when you've time? then I'll get it merged first thing before merging other PRs

Done

}
// if (useOptional) {
// writePropertyBack(USE_OPTIONAL, useOptional);
// }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpfinne overall it looks good. May I know why these 3 lines are commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed


return tmpl.execute(bundle);
Object parent = bundle.get(CodegenConstants.CONFIG);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add comments explaining what this code block does and what exactly is CodegenConstants.CONFIG?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments added
CONFIG renamed to MUSTACHE_PARENT_CONTEXT

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. that's much better

@wing328
Copy link
Member

wing328 commented Jun 17, 2024

cc @OpenAPITools/generator-core-team

@wing328
Copy link
Member

wing328 commented Jun 17, 2024

we can merge it to start with. i've a few more qeustions/suggestions that I'll discuss with you via Slack

@wing328 wing328 merged commit 129e4dc into OpenAPITools:master Jun 17, 2024
26 checks passed
@wing328 wing328 added this to the 7.7.0 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants