-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Fix #18715 [JAVA] ensure codegen fields and additionalProperties are not conflicting #18935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #18715 [JAVA] ensure codegen fields and additionalProperties are not conflicting #18935
Conversation
can you please resolve the merge conflicts when you've time? then I'll get it merged first thing before merging other PRs |
Done |
} | ||
// if (useOptional) { | ||
// writePropertyBack(USE_OPTIONAL, useOptional); | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpfinne overall it looks good. May I know why these 3 lines are commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
|
||
return tmpl.execute(bundle); | ||
Object parent = bundle.get(CodegenConstants.CONFIG); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add comments explaining what this code block does and what exactly is CodegenConstants.CONFIG?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments added
CONFIG renamed to MUSTACHE_PARENT_CONTEXT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. that's much better
cc @OpenAPITools/generator-core-team |
we can merge it to start with. i've a few more qeustions/suggestions that I'll discuss with you via Slack |
Only write back to additionalProperties if it was present
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)