[Ruby] Fix Content-Transfer-Encoding binary unpacking #19132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please update the samples (step 3) so that CI can verify the fix |
|
@wing328 I've gone through this a few times, and nothing changes; but it could be because some of the threads crash out on the second command: |
|
Oh, looks like I can run just the ruby ones. |
|
lgtm. let's give it a try thanks for the fix |
|
I think this needs to be updated to be content = content.unpack('m').join if response.headers['Content-Transfer-Encoding'] == 'binary' && !content.starts_with?('%PDF-') |
|
@sirwolfgang I believe your patch actually broke things further rather than fix them.
What you've added is doing things backwards - when the header is set to To make this work correctly, the actual conditional might be: content = content.unpack('m').join if response.headers['Content-Transfer-Encoding'] == 'base64' but I'm not sure if this is not already handled by Faraday and based on your description I believe this might not have been the original cause of your problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my findings attempting to download PDFs with a downstream gem, I discovered that binary transferred data is never being unpacked into it's native format. This renders the results malformed. mxenabled/mx-platform-ruby#90
This PR adds a patch that simplifies the flow control of the
deserializemethod, while updating it to properly deserialize content from binary transfer encoding.I have a patch of this running downstream in production.
Ruby Committee: @cliffano @zlx @autopp
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)