-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[Python] Harmonize python client dependency versions #19694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thanks for the PR if no further question/feedback, i'll merge it this coming wed or later this week |
Thanks @petercinibulk ! Fixed in #19773. |
@bachorp thanks for the quick fix, which has been merged. @petercinibulk thanks for pointing out the issue |
@@ -12,12 +12,12 @@ include = ["petstore_api/py.typed"] | |||
[tool.poetry.dependencies] | |||
python = "^3.8" | |||
|
|||
urllib3 = ">= 1.25.3" | |||
python-dateutil = ">=2.8.2" | |||
urllib3 = ">= 1.25.3 < 3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong poetry version annotation.
Breaks pdm converter.
Should be:
urllib3 = "~=1.25.3"
python-dateutil = ">=2.8.2" | ||
pydantic = ">=2" | ||
typing-extensions = ">=4.7.1" | ||
urllib3 = ">= 1.25.3 < 3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong poetry version annotation.
Breaks pdm converter.
Should be:
urllib3 = "~=1.25.3"
python-dateutil = ">=2.8.2" | ||
pydantic = ">=2" | ||
typing-extensions = ">=4.7.1" | ||
urllib3 = ">= 1.25.3 < 3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong poetry version annotation.
Breaks pdm converter.
Should be:
urllib3 = "~=1.25.3"
The requested Python / package versions should be the same irrespective of the particular tool (Pip / Setuptools / Poetry, Gitlab CI / Travis / Github Actions).
@cbornet @tomplus @krjakbrjak @fa0311 @multani
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)