Skip to content

[nim] Fix nim code generation in case of an endpoint for which schema defines both query parameters and multipart/form-data #20752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

sandwoodK
Copy link
Contributor

@sandwoodK sandwoodK commented Feb 27, 2025

Same parameter name declared multiple time in the same scope. => nim generated code does not compile.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@sandwoodK
Copy link
Contributor Author

@hokamoto
this is a fix, because generated nim code does not compile if an endpoint have both query parameters and multipart form data

@wing328
Copy link
Member

wing328 commented Feb 28, 2025

thanks for the PR

can you please update the samples to fix the CI failure?

@sandwoodK sandwoodK changed the title Fix nim code generation [nim] Fix nim code generation in case of an endpoint for which schema defines both query parameters and multipart/form-data Mar 1, 2025
Same variable name declared multiple times in the same scope.
=> nim generated code does not compile.
@sandwoodK
Copy link
Contributor Author

Done.
I've amended the previous commit to update samples.

@wing328 wing328 added this to the 7.13.0 milestone Mar 3, 2025
@wing328
Copy link
Member

wing328 commented Mar 3, 2025

the fix looks good to me

thanks for the contribution.

@wing328 wing328 merged commit e0b6b2b into OpenAPITools:master Mar 3, 2025
16 checks passed
JacobOJ pushed a commit to JacobOJ/openapi-generator that referenced this pull request Mar 3, 2025
Same variable name declared multiple times in the same scope.
=> nim generated code does not compile.
kpy3 pushed a commit to kpy3/openapi-generator that referenced this pull request Mar 13, 2025
Same variable name declared multiple times in the same scope.
=> nim generated code does not compile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants