Skip to content

[dart-dio][timemachine] Bugfix: Ensure closing bracket when adding serializers #20908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

epou
Copy link
Contributor

@epou epou commented Mar 17, 2025

Using dart-dio with timemachine leads to syntax error in lib/src/serializers.dart -> Expected to find ')'

It seems the bug was introduced here #9180 (see file), where there's a closing bracket for {{#useDateLibCore}} ....... {{/useDateLibCore}} but not for {{#useDateLibTimeMachine}} ....... {{/useDateLibTimeMachine}}.

Adding the bracket just before the .build to ensure it is always closed, independent of what's defined in previous lines...


PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)

@kuhnroyal
Copy link
Contributor

LGTM, thanks!

@kuhnroyal
Copy link
Contributor

@wing328

@wing328
Copy link
Member

wing328 commented Mar 19, 2025

ci failure (already fixed in master) not related to this change

@wing328 wing328 merged commit a2ee3a7 into OpenAPITools:master Mar 19, 2025
14 of 16 checks passed
@wing328 wing328 added this to the 7.13.0 milestone Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants