Skip to content

Better handling of metadata in allOf #21342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

Better handling of metadata in allOf #21342

merged 2 commits into from
May 30, 2025

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 28, 2025

  • better handling of metadata in allOf by normalization/refactoring in normalizer
  • add tests

fyi @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Inline Schema Handling Schema contains a complex schema in items/additionalProperties/allOf/oneOf/anyOf OpenAPI Normalizer Normalize the spec for easier processing labels May 28, 2025
@wing328 wing328 changed the title better handling of metadata in allof Better handling of metadata in allOf May 29, 2025
@wing328 wing328 marked this pull request as ready for review May 30, 2025 12:37
@wing328 wing328 merged commit 1b57d4b into master May 30, 2025
20 of 21 checks passed
@wing328 wing328 deleted the allof-default branch May 30, 2025 12:37
@wing328 wing328 added this to the 7.14.0 milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Inline Schema Handling Schema contains a complex schema in items/additionalProperties/allOf/oneOf/anyOf OpenAPI Normalizer Normalize the spec for easier processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant