[aspnetcore] more configurable and generate abstract class library #2282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
4 tasks
|
Oh saw this afterwards - thanks!
Need to see how to avoid the rebase issue in the future.
…On 3/2/19 10:02 AM, William Cheng wrote:
PR checklist
* Read the contribution guidelines
<https://github.com/openapitools/openapi-generator/blob/master/CONTRIBUTING.md>.
* Ran the shell script under |./bin/| to update Petstore sample so
that CIs can verify the change. (For instance, only need to run
|./bin/{LANG}-petstore.sh|, |./bin/openapi3/{LANG}-petstore.sh|,
|./bin/security/{LANG}-petstore.sh| and
|./bin/openapi3/security/{LANG}-petstore.sh| if updating the
{LANG} (e.g. php, ruby, python, etc) code generator or {LANG}
client's mustache templates). Windows batch files can be found in
|.\bin\windows\|.
* Filed the PR against the correct branch
<https://github.com/OpenAPITools/openapi-generator/wiki/Git-Branches>:
|master|, |3.4.x|, |4.0.x|. Default: |master|.
* Copied the technical committee
<https://github.com/openapitools/openapi-generator/#62---openapi-generator-technical-committee>
to review the pull request if your PR is targeting a particular
programming language.
Description of the PR
cherry-pick #2181
<#2181>
cc @A-Joshi <https://github.com/A-Joshi>
------------------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
#2282
Commit Summary
* Add ability control out put generation and support to generate a
library
* Roll back pom version - it seems to break the CI/CD checks
* Roll back pom version - it seems to break the CI/CD checks
* Match with genrators - no changes from new code
* Fix inadvertent changes
* No idea why the names of params have changed pet to body for instance
* Match generated document
* Clarify logic as per PR review
* Remove the generatewwwroot option and use the buildtarget option
* Remove ar artifactVerson (not used), update docs and TODO notes
* Add ability control out put generation and support to generate a
library
* Roll back pom version - it seems to break the CI/CD checks
* Roll back pom version - it seems to break the CI/CD checks
* Fix inadvertent changes
* Match generated document
* Add ability control out put generation and support to generate a
library
* Roll back pom version - it seems to break the CI/CD checks
* Roll back pom version - it seems to break the CI/CD checks
* Fix inadvertent changes
* Match generated document
* Clarify logic as per PR review
* Remove the generatewwwroot option and use the buildtarget option
* Remove ar artifactVerson (not used), update docs and TODO notes
File Changes
* *M* docs/generators/aspnetcore.md
<https://github.com/OpenAPITools/openapi-generator/pull/2282/files#diff-0>
(9)
* *M*
modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractCSharpCodegen.java
<https://github.com/OpenAPITools/openapi-generator/pull/2282/files#diff-1>
(21)
* *M*
modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AspNetCoreServerCodegen.java
<https://github.com/OpenAPITools/openapi-generator/pull/2282/files#diff-2>
(148)
* *M*
modules/openapi-generator/src/main/resources/aspnetcore/2.1/Project.csproj.mustache
<https://github.com/OpenAPITools/openapi-generator/pull/2282/files#diff-3>
(2)
* *A*
modules/openapi-generator/src/main/resources/aspnetcore/2.1/Project.nuspec.mustache
<https://github.com/OpenAPITools/openapi-generator/pull/2282/files#diff-4>
(20)
* *M*
modules/openapi-generator/src/main/resources/aspnetcore/2.1/controller.mustache
<https://github.com/OpenAPITools/openapi-generator/pull/2282/files#diff-5>
(9)
* *M* samples/server/petstore/aspnetcore/.openapi-generator/VERSION
<https://github.com/OpenAPITools/openapi-generator/pull/2282/files#diff-6>
(2)
* *M*
samples/server/petstore/aspnetcore/src/Org.OpenAPITools/Controllers/PetApi.cs
<https://github.com/OpenAPITools/openapi-generator/pull/2282/files#diff-7>
(10)
* *M*
samples/server/petstore/aspnetcore/src/Org.OpenAPITools/Controllers/StoreApi.cs
<https://github.com/OpenAPITools/openapi-generator/pull/2282/files#diff-8>
(6)
* *M*
samples/server/petstore/aspnetcore/src/Org.OpenAPITools/Controllers/UserApi.cs
<https://github.com/OpenAPITools/openapi-generator/pull/2282/files#diff-9>
(18)
* *M*
samples/server/petstore/aspnetcore/src/Org.OpenAPITools/wwwroot/openapi-original.json
<https://github.com/OpenAPITools/openapi-generator/pull/2282/files#diff-10>
(25)
Patch Links:
* https://github.com/OpenAPITools/openapi-generator/pull/2282.patch
* https://github.com/OpenAPITools/openapi-generator/pull/2282.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2282>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ANQEIbt1I9ElJULVdkIEWN5evM-q34RKks5vSpKUgaJpZM4babU0>.
|
* master: Fix 2278: migrate the docker image for the aspnetcore generator (#2281)
|
I fixed the merge conflict in a version file, and pushed to the branch. |
wing328
changed the title
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
cherry-pick #2181
cc @A-Joshi