[Python][Flask] pythonic params #2374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 12, 2019 14:15
…file correct with reference to the original spec file.
… conversion of the OpenAPI spec file in Python server implementation(s).
wing328
reviewed
Mar 22, 2019
...r/src/main/java/org/openapitools/codegen/languages/PythonAbstractConnexionServerCodegen.java
Show resolved
Hide resolved
wing328
reviewed
Aug 8, 2019
| required: false | ||
| schema: | ||
| type: integer | ||
| format: int32 |
There was a problem hiding this comment.
We'll remove this as we want to keep it in sync with petstore.yaml (OAS v2)
Additional test cases should go to https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing.yaml instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
We have an OpenAPI spec file with
camelCase(query and path) parameters.When generating a Python (
connexion-based) server those parameters are converted to ("pythonic")snake_caseparameters.During generation of the supporting files there is also an OpenAPI spec file generated for use with
connexion. This spec file does not match the original one regarding parameter names.Especially when defining "query" parameters, the REST interface will be different than the one defined in the original OpenAPI spec file.
Such (query) parameters are incompatible with generated clients (and other server implementations)
Fixes #1671
We have been using this fix some time on a local checkout for generating
python-flaskserver implementations without issues.Notes
This PR also updates the
python-aiohttpbut it is untested.Please feel free to try it out.
These changes do not limit on query or path parameters and should also work on header and cookie parameters.