Skip to content

[Java][C#][JS] remove localVariablePrefix #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 18, 2019
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Mar 16, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

The option has been deprecated as all local variables are prefixed with "localVar"

cc
@mandrean (2017/08), @jimschubert (2017/09)

@CodeNinjai (2017/07) @frol (2017/07) @cliffano (2017/07)

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

@wing328 wing328 added this to the 4.0.0 milestone Mar 16, 2019
@wing328 wing328 changed the title [Java] remove localVariablePrefix from templates [Java] remove localVariablePrefix Mar 16, 2019
@wing328 wing328 changed the title [Java] remove localVariablePrefix [Java][C#][JS] remove localVariablePrefix Mar 17, 2019
@wing328 wing328 merged commit d18bf04 into master Mar 18, 2019
@wing328 wing328 deleted the clean-up-localVariablePrefix branch March 18, 2019 02:46
@wing328
Copy link
Member Author

wing328 commented Apr 28, 2019

Upgrade Note

The option localVariablePrefix has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant