Skip to content

Add RuboCop to Gemfile #2464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Add RuboCop to Gemfile #2464

merged 2 commits into from
Mar 21, 2019

Conversation

ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Mar 20, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

closes #2444

./bin/openapi3/ruby-client-petstore.sh
./bin/ruby-client-petstore.sh
@spacether
Copy link
Contributor

spacether commented Mar 21, 2019

@ackintosh @wing328 it looks like Shippable is having problems installing some packages and the right version of Elixir. Per your log:

E: Failed to fetch http://packages.erlang-solutions.com/debian/pool/elixir_1.8.1-2~ubuntu~xenial_amd64.deb  Unable to connect to packages.erlang-solutions.com:http:

Per mine from: https://app.shippable.com/github/OpenAPITools/openapi-generator/runs/6788/1/console
It installed Elixir 1.1.0-dev when we had previously been installing Elixir 1.8.1 per the last successful shippable build here: https://app.shippable.com/github/OpenAPITools/openapi-generator/runs/6786/1/console

@wing328
Copy link
Member

wing328 commented Mar 21, 2019

The CI failures are not related to this PR.

@wing328 wing328 merged commit 77545df into OpenAPITools:master Mar 21, 2019
@ackintosh ackintosh deleted the add-rubocop branch March 22, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] Add RuboCop to Gemfile
3 participants