[C++][RestSDK] Windows vcpkg vs2017 support #2751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with upstream
Sync with upstream
Sync with upstream
etherealjoy
changed the title
etherealjoy
reviewed
Apr 27, 2019
modules/openapi-generator/src/main/resources/cpp-rest-sdk-client/api-header.mustache
Outdated
Show resolved
Hide resolved
|
I got a warning with this during compilation /home/dev/openapi-generator/samples/client/petstore/cpp-restsdk/api/../ApiClient.h:31:14:
warning: extra tokens at end of #ifdef directive
#ifdef _WIN32|_WIN64I tried this syntax below and I think it would be more suitable due to no warning. #if defined (_WIN32) || defined (_WIN64)
#undef U
#endif |
|
Alright, I also switched my branch to recommended. #if defined (_WIN32) || defined (_WIN64). |
etherealjoy
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
This addresses comments made in #2747 (Better support for vckpg and visual studio 2017).
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
Fixes #2747