Skip to content

[C++] Use super class methods for Model and Api Filenames #2787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

etherealjoy
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Simplify model and api file name by using methods from super class AbstractCppCodegen

@stkrwork @MartinDelille @fvarose @ravinikam

Copy link
Contributor

@stkrwork stkrwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
However, is the tizen generator also already adapted, or does it require a lot more changes anyway?

@etherealjoy
Copy link
Contributor Author

etherealjoy commented May 1, 2019

Tizen has its own implementation. I think some rework needs to be done.
I will check it and see if we can update it to use the super class methods wherever possible.

@etherealjoy etherealjoy merged commit 561c1e0 into OpenAPITools:master May 3, 2019
@etherealjoy etherealjoy added this to the 4.0.0 milestone May 3, 2019
@etherealjoy etherealjoy deleted the cpp-use-super-class-methods branch September 16, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants