Skip to content

[JAVA] fix artifactVersion is not taken from specification #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

karismann
Copy link
Contributor

when not provided by generator option

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @Zomzog (2019/04)

Description of the PR

fix #1815
fix #2033 PR feature :

  • If no artifactVersion is provided in additional properties, version from API specification is used. If none of them is provided then fallbacks to default version (1.0.0)

@karismann karismann closed this May 6, 2019
@karismann karismann reopened this May 6, 2019
@karismann karismann force-pushed the JAVA-artifactVersion-is-not-taken-from-specification branch from b1f6623 to 81fbd32 Compare May 7, 2019 08:35
@wing328 wing328 added this to the 4.0.0 milestone May 9, 2019
@wing328 wing328 merged commit 70108b7 into OpenAPITools:master May 9, 2019
@karismann karismann deleted the JAVA-artifactVersion-is-not-taken-from-specification branch May 9, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][CLIENT][JAVA] artifactVersion is not taken from specification
2 participants