[java/resttemplate] Generate valid code if no Authentication implementations present

[jonfreedman]

Take the logic used to decide which instances to add to the authentications map and re-use to not import classes or offer non-functional util methods

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog

[wing328]

@jonfreedman thanks for the PR. Look like the change will results in duplicated import org.openapitools.client.auth.ApiKeyAuth:

--- a/samples/client/petstore/java/resttemplate-withXml/src/main/java/org/openapitools/client/ApiClient.java
+++ b/samples/client/petstore/java/resttemplate-withXml/src/main/java/org/openapitools/client/ApiClient.java
@@ -59,12 +59,12 @@ import java.util.Map.Entry;
 import java.util.TimeZone;
 
 import org.openapitools.client.auth.Authentication;
-import org.openapitools.client.auth.HttpBasicAuth;
-import org.openapitools.client.auth.HttpBearerAuth;
+
+import org.openapitools.client.auth.ApiKeyAuth;
 import org.openapitools.client.auth.ApiKeyAuth;
+import org.openapitools.client.auth.HttpBasicAuth;
 import org.openapitools.client.auth.OAuth;

[jonfreedman]

Can you please check the population of the authentications map, if there's a duplicate import I guess there must be a duplicate put too?
If that's the case do you think it's better to add more variables like hasOAuthMethods instead?

[wing328]

Yes, we have {{#hasOAuthMethods}} ... {{/hasOAuthMethods}}, e.g. https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/Java/libraries/okhttp-gson/pom.mustache#L221

[jonfreedman]

Yep I saw that one, but would also need hasBasicAuthMethods, hasTokenAuthMethods etc. which I assume don't exist yet?

[wing328]

but would also need hasBasicAuthMethods, hasTokenAuthMethods etc. which I assume don't exist yet?

Can you please add hasBasicAuthMethods, hasTokenAuthMethods, etc as part of this PR?

[jonfreedman]

I can give it a go - can you point me in the right direction?

[wing328]

openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultGenerator.java

Line 1276 in 9323cad

private boolean hasOAuthMethods(List<CodegenSecurity> authMethods) {

is a good starting point.

And then add similar checks in

openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultGenerator.java

Line 842 in 9323cad

if (hasOAuthMethods(authMethods)) {

Let me know if you need further info.

Thanks for helping us to add these methods.

[wing328]

Closing this as there's no update. Please open a new one when you've time.

Thanks again for the PR.