Skip to content

[java-okhttp]: Make example snippets code compilable #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

saigiridhar21
Copy link
Contributor

@saigiridhar21 saigiridhar21 commented May 28, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

#3017

Make example snippets code compilable. Also, specify how to access response message and headers in case of request failure.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04)

@auto-labeler
Copy link

auto-labeler bot commented May 28, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@saigiridhar21 saigiridhar21 force-pushed the javaokhttpgson-make-example-executable branch from e952266 to 0201e19 Compare May 28, 2019 05:04
@saigiridhar21 saigiridhar21 force-pushed the javaokhttpgson-make-example-executable branch from 0201e19 to de190da Compare May 28, 2019 05:32
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit f93e75b into OpenAPITools:master May 28, 2019
@saigiridhar21 saigiridhar21 deleted the javaokhttpgson-make-example-executable branch May 29, 2019 08:13
@wing328 wing328 added this to the 4.0.1 milestone May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants