Skip to content

[C++][Pistache] Fix warnings #3238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2019

Conversation

muttleyxd
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
    @ravinikam @stkrwork @etherealjoy @MartinDelille

Description of the PR

GCC would complain about two warnings

(...)/api/(...)Api.cpp:24:92: warning: extra ‘;’ [-Wpedantic]
 (...)Api::(...)Api(std::shared_ptr<Pistache::Rest::Router> rtr) { router = rtr; };
(..)/api/(...)Api.cpp: In member function ‘void org::openapitools::server::api::(...)Api::(...)_api_default_handler(const Pistache::Rest::Request&, Pistache::Http::ResponseWriter)’:
(...)/api/(...)Api.cpp:124:69: warning: unused parameter ‘request’ [-Wunused-parameter]
 void (...)Api::(...)_api_default_handler(const Pistache::Rest::Request& request,

@muttleyxd muttleyxd changed the title Fix pistache warnings [C++][Pistache] Fix warnings Jun 28, 2019
Remove unecessary semicolon (Wpedantic)
Remove unused parameter name (Wunused-parameter)
@muttleyxd muttleyxd force-pushed the fix-pistache-warnings branch from 169849b to 864246d Compare June 28, 2019 12:37
@etherealjoy etherealjoy merged commit 731b162 into OpenAPITools:master Jun 28, 2019
@etherealjoy etherealjoy added this to the 4.0.3 milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants