Set error_reporting(E_ALL) in phpunit.xml settings, to crash on undefined variables #3266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… variables will always cause a test failure
|
Sorry the |
|
@ndbroadbent thanks for the PR. I also prefer "strick" check as I encountered the same issue when learning PHP like 20 years ago :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
Hello! One of my customers was using my PHP client library, and they told me that it was crashing with an undefined variable (in some custom code that I added.) I write a set of integration tests that check that everything is working, and these tests were all passing, but I didn't know that PHP doesn't crash on undefined variables by default. I figured out that I can enforce this "strict" check by adding this option to the
phpunit.xmlfile:<ini name="error_reporting" value="E_ALL" />I'm not too familiar with PHP, but I think this behavior would probably be a sane default for anyone who wants to write tests for their PHP libraries.
CC
@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ackintosh (2017/09) ❤️, @ybelenko (2018/07), @renepardon (2018/12)