Skip to content

Fix callback request and response not being flattened to InlineObjects #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2019

Conversation

lwlee2608
Copy link
Contributor

@lwlee2608 lwlee2608 commented Jul 19, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix #3397 callback request and response not being flattened to InlineObjects

cc @wing328 @jimschubert @cbornet @ackintosh @jmini @etherealjoy

@lwlee2608
Copy link
Contributor Author

@wing328 Hello, Can you kindly take a look at the PR please?

@ackintosh
Copy link
Contributor

Thanks for this PR! I'll take a look. ✨

Copy link
Contributor

@ackintosh ackintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@ackintosh ackintosh merged commit 7e8c7db into OpenAPITools:master Aug 17, 2019
@ackintosh ackintosh added this to the 4.1.1 milestone Aug 17, 2019
@lwlee2608
Copy link
Contributor Author

Thanks!

@wing328 wing328 changed the title Fix for issue #3397 Fix callback request and response not being flattened to InlineObjects Aug 17, 2019
@wing328
Copy link
Member

wing328 commented Aug 26, 2019

@lwlee2608 thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Callback request and response not being flattened to InlineObjects
3 participants