Skip to content

[C++][Qt5] Remove QRandomGenerator #3508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

etherealjoy
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Remove QRandomGenerator from the tests.
It adds unneeded dependency to Qt 5.10 which can be done by a simple rand() function

cc

@MartinDelille

@etherealjoy
Copy link
Contributor Author

Merging this small change directly.

@etherealjoy etherealjoy added this to the 4.1.0 milestone Aug 1, 2019
@etherealjoy etherealjoy merged commit 08415d1 into OpenAPITools:master Aug 1, 2019
@etherealjoy etherealjoy deleted the remove_qrandomgenerator branch September 16, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant