Skip to content

[Ruby] remove auto-generated Gemfile.lock #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 3, 2019
Merged

[Ruby] remove auto-generated Gemfile.lock #3541

merged 5 commits into from
Aug 3, 2019

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Aug 2, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • remove auto-generated Gemfile.lock as the lock file should be created as part of the installation process.

cc @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

@wing328 wing328 added this to the 4.1.0 milestone Aug 2, 2019
@autopp
Copy link
Contributor

autopp commented Aug 3, 2019

@wing328 Looks good. Would you like to delete Gemfile.lock in sample as well?

@wing328
Copy link
Member Author

wing328 commented Aug 3, 2019

Done via d668b32a1b.

@wing328 wing328 merged commit 86228e9 into master Aug 3, 2019
@wing328
Copy link
Member Author

wing328 commented Aug 3, 2019

I'll check the build status later to ensure the ruby tests are fine.

@wing328 wing328 deleted the remove-gem-lock branch August 3, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants