Use the latest version of superagent. #3579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oponder thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intro
Hi! Thanks for this great project :D
This is a small PR to upgrade superagent in the generated javascript clients.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
Upgrade superagent to version 5.1.0, since versions lower than 3.8.1 have a security vulnerability.
https://app.snyk.io/vuln/npm:superagent:20181108
We had been getting around this by manually editing the generated package.json each time.
5.1.0seems like a big leap, but there appear to be no relevant breaking changes, at least not for our client: https://github.com/visionmedia/superagent#upgrading-from-previous-versionsSo I believe this could be filed against
master, but please correct me if I'm wrong!Of course, I lack the full overview on what might break, so requesting a second pair of eyes, and confirmation here.
cc: @jfiala, @achew22, @jaypea
Regarding "Ran the shell script under
./bin/" from the PR checklist, I think I ran./bin/javascript-petstore-all,./bin/openapi3/javascript-es6-petstore.shand./bin/openapi3/javascript-closure-angular.shDoes that cover it all? Wasn't sure about the right thing to do here.
Quite some more changes than expected came in though in the examples.