-
-
Notifications
You must be signed in to change notification settings - Fork 7k
feature/add-avro-generator #3662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
cc @OpenAPITools/generator-core-team |
modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AvroCodegen.java
Outdated
Show resolved
Hide resolved
What is the use to convert OAS to Avro ? Avro only deals with the ser/deser part and not with the API/HTTP part. |
@cbornet it's common for larger microservice infrastructure to define common types between services which may be consumed by teams that don't own the data. Those structures may be evented through a bus like Kafka, where it would be beneficial to have a clearly defined binary transport. It may also be helpful to generate a public API structure as we do now, but then generate the avro structures for persisting the same API data for external processing via Spark. In all of these cases, Avro would be hugely beneficial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.
Let me know if you need help fixing it.
thanks for remark
I added the mail used for commits to my account and it's ok now i think
modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AvroCodegen.java
Outdated
Show resolved
Hide resolved
I'll file another PR for minor enhancements and fixes for the CircleCI failure. |
Filed #3728 |
@sgadouar thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737 |
PR checklist
Read the contribution guidelines.
Ran the shell script under
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.Filed the PR against the correct branch:
master
,4.1.x
,5.0.x
. Default:master
.Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
New avro generator plugin
https://avro.apache.org/docs/current/#schemas
input: open-api specification
output: avro schemas files