Skip to content

typescript-angular: set angular version 8 as default for ngVersion #3680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2019
Merged

typescript-angular: set angular version 8 as default for ngVersion #3680

merged 2 commits into from
Aug 20, 2019

Conversation

macjohnny
Copy link
Member

@macjohnny macjohnny commented Aug 19, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

set angular 8 as the default version

@macjohnny macjohnny changed the title set angular version 8 as default for ngVersion typescript-angular: set angular version 8 as default for ngVersion Aug 19, 2019
@macjohnny macjohnny added this to the 4.2.0 milestone Aug 19, 2019
@macjohnny
Copy link
Member Author

cc @akehir

@akehir
Copy link
Contributor

akehir commented Aug 19, 2019

LGTM.

@macjohnny macjohnny merged commit e5912b4 into OpenAPITools:4.2.x Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants