-
-
Notifications
You must be signed in to change notification settings - Fork 7k
add gradle repository for using gralde dependency in plugin #3867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gradle repository for using gralde dependency in plugin #3867
Conversation
@fujigon what are the conditions that might cause this? Do you have a modified Maven settings.xml? And what version of Maven? We don't really build the Gradle plugin via Maven, so it might be better to remove it and just rely on CI to report build issues in the plugin. @wing328 any thoughts? If no concerns, we may want to merge after 4.1.2 is released. Workaround for whatever environment conditions cause this would be for the user to manually add the above configuration locally. |
I'm still gathering the facts, please give me a moment. |
can reproduce the error in some environments, cannot do in other environments. Following command will reproduce the error though I found the issue while I run my complicated mvn commands for my internal package release to my private maven repository.
I confirmed that all my trial invoke When succeeds, I get
When fails, I get
environment 1 error occurs(I challenged all combination, i.e. 8 patterns)
environment 2 error occurs
environment 3 no error
environment 4 no error
|
@jimschubert could you please check my error environment report please? thanks! :) |
confirmed this PR will
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pom file:
<groupId>org.openapitools</groupId>
<artifactId>openapi-generator-gradle-plugin-mvn-wrapper</artifactId>
<version>4.1.2-SNAPSHOT</version>
Is not something we release. It is only here to trigger gradle as part of the maven build.
It does not seems to hurt to give maven an additional way to fetch the dependencies requested for one of the plugins used in this pom.
* master: (207 commits) Add missing enum processing in C++ codegen, already present for Qt5 (#3986) [C++] [Pistache] Removed deprecated warnings (#3985) [C++][Pistache] Simplified model template (#3417) add go oas3 petstore to ensure up-to-date (#3979) replace gitter with slack in the doc (#3977) Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971) #3957 - Removed hardcoded baseUrl (#3964) Regenerate go openapi3 samples (#3975) [rust] Make it easier to test rust client generator (#3543) Fix issue3635 (#3948) add gradle repository (#3867) [java] allow to use setArtifactVersion() programmatically (#3907) Add a link to DevRelCon SF 2019 (#3961) Add a link to a medium blog post (#3960) update maven-compiler-plugin version (#3956) fix generateAliasAsModels in default generator (#3951) Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910) Add F# Functions server generator (#3933) [python-experimental] generate model if type != object if enums/validations exist (#2757) [scala] add [date-time] field to codegen unit test (#3939) ...
* master: (110 commits) [golang] Regenerate all go samples (#3988) Better tests for string (number) (#3953) Add missing enum processing in C++ codegen, already present for Qt5 (#3986) [C++] [Pistache] Removed deprecated warnings (#3985) [C++][Pistache] Simplified model template (#3417) add go oas3 petstore to ensure up-to-date (#3979) replace gitter with slack in the doc (#3977) Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971) #3957 - Removed hardcoded baseUrl (#3964) Regenerate go openapi3 samples (#3975) [rust] Make it easier to test rust client generator (#3543) Fix issue3635 (#3948) add gradle repository (#3867) [java] allow to use setArtifactVersion() programmatically (#3907) Add a link to DevRelCon SF 2019 (#3961) Add a link to a medium blog post (#3960) update maven-compiler-plugin version (#3956) fix generateAliasAsModels in default generator (#3951) Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910) Add F# Functions server generator (#3933) ...
@fujigon thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456 |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master
,4.1.x
,5.0.x
. Default:master
.Description of the PR
org.gradle:gradle-tooling-api
is on Gradle Releases repository (cf. https://mvnrepository.com/artifact/org.gradle/gradle-tooling-api/4.10.2)So, we need to add this repository to
pluginManagement
.Without this setting, following error will occur in some environment.
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)