Fixes invalid Kotlin client variable names for reserved words #3993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Kotlin Multiplatform client introduced an bug that rendered variable names that were also Kotlin reserved words incorrectly. This change reverts the template to use the previous mechanism for rendering variable names. OpenAPITools#3992
|
@wing328 Apologies. I introduced a breaking change to Kotlin clients with the addition of Kotlin Multiplatform. The original branch (from Swagger Codegen) required a workaround to escape Kotlin identifiers. This workaround is no longer necessary (on OpenAPI) and breaks existing Kotlin clients that have identifers that are Kotlin reserved words. This change removes the workaround in favour of the existing approach. |
That's ok. Thanks for letting us know and the quite fix. |
|
The fix looks good. |
Jesse0Michael
pushed a commit
to Jesse0Michael/openapi-generator
that referenced
this pull request
Oct 3, 2019
…ITools#3993) The Kotlin Multiplatform client introduced an bug that rendered variable names that were also Kotlin reserved words incorrectly. This change reverts the template to use the previous mechanism for rendering variable names. OpenAPITools#3992
|
@andrewemery thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kotlin Multiplatform client introduced an bug that rendered variable names that were also Kotlin reserved words incorrectly. This change reverts the template to use the previous mechanism for rendering variable names.
#3992