Skip to content

Fix file type in avro template #4105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Fix file type in avro template #4105

merged 2 commits into from
Oct 9, 2019

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Oct 9, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

For #4078 (comment)

@wing328 wing328 added this to the 4.2.0 milestone Oct 9, 2019
@wing328 wing328 added Schema: Avro Generation of Avro schemas Issue: Bug labels Oct 9, 2019
@wing328
Copy link
Member Author

wing328 commented Oct 9, 2019

cc @Choobz @sgadouar

@wing328
Copy link
Member Author

wing328 commented Oct 9, 2019

Shippable error not related to this PR.

@wing328 wing328 merged commit e9a0a51 into master Oct 9, 2019
@wing328 wing328 deleted the avro-fix-file branch October 9, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Schema: Avro Generation of Avro schemas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant