Skip to content

[Go] Upgrade dependencies #4126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2019
Merged

[Go] Upgrade dependencies #4126

merged 1 commit into from
Oct 17, 2019

Conversation

urandom2
Copy link
Contributor

@urandom2 urandom2 commented Oct 11, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

antihax/optional#1 added module support, and was tagged as a stable
release. This change consumes that tag, and updates the psuedo-version
for golang.org/x/oauth2.

CC

@antihax @bvwells @grokify @kemokemo @bkabrda

Updates #4083.

@wing328
Copy link
Member

wing328 commented Oct 13, 2019

@arnottcr thanks for the PR. I wonder if you can make the same change to the corresponding templates in the go-experimental generator as well:

antihax/optional#1 added module support, and was tagged as a stable
release. This change consumes that tag, and updates the psuedo-version
for golang.org/x/oauth2.
@wing328
Copy link
Member

wing328 commented Oct 17, 2019

On branch arnottcr-go-modules
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   samples/openapi3/client/petstore/go/go-petstore/go.mod
	modified:   samples/openapi3/client/petstore/go/go-petstore/go.sum

I'll update the outdated samples in another commit.

@wing328 wing328 merged commit 0809918 into OpenAPITools:master Oct 17, 2019
@wing328
Copy link
Member

wing328 commented Oct 31, 2019

@arnottcr thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants