Skip to content

[python] Remove post_params and body from OPTIONS request #4163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Oct 16, 2019
Merged

[python] Remove post_params and body from OPTIONS request #4163

merged 2 commits into from Oct 16, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 15, 2019

https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/OPTIONS

Options should not have body or post_params

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before .
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@ghost ghost changed the title Remove post_params and body from OPTIONS Remove post_params and body from OPTIONS request Oct 15, 2019
@ghost
Copy link
Author

ghost commented Oct 15, 2019

@taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01)

cc: @wing328

@ghost
Copy link
Author

ghost commented Oct 15, 2019

I think this build is failing because docker pull swagger/petstore is resulting in 503

@spacether
Copy link
Contributor

I think this build is failing because docker pull swagger/petstore is resulting in 503

Yup, I am seeing that too on my PR. Locally running docker pull swaggerapi/petstore results in:

Using default tag: latest
Error response from daemon: received unexpected HTTP status: 503 Service Unavailable

@ghost ghost changed the title Remove post_params and body from OPTIONS request [python] Remove post_params and body from OPTIONS request Oct 15, 2019
@wing328
Copy link
Member

wing328 commented Oct 16, 2019

There were docker outages.

Your PR looks good so I'll merge it. (and python petstore samples are tested by Travis)

@wing328 wing328 merged commit 095fa71 into OpenAPITools:master Oct 16, 2019
@wing328 wing328 added this to the 4.2.0 milestone Oct 16, 2019
@ghost ghost deleted the remove_body_from_options branch October 16, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants