Skip to content

Fix Kotlin query collection format #4248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrewemery
Copy link
Contributor

@andrewemery andrewemery commented Oct 24, 2019

Fixes incorrect query header collection constants

The OpenAPI generator converts OpenAPI v2 documents into an OpenAPI v3
representation. The query parameter collection formats are squeezed
into different values from the raw OpenAPI 2 collection format values.

For example: csv -> space

See: DefaultCodegen#getCollectionFormat

To fix #4285

The OpenApi codegen converts OpenApi v2 documents into an OpenApi v3
representation. The query parameter collection formats are squeezed
into different values from the raw OpenApi 2 collection format values.
For example: csv -> space
See: DefaultCodegen#getCollectionFormat
@andrewemery andrewemery force-pushed the kotlin-query-collection-format branch from 06bc9af to ee1ccda Compare October 28, 2019 09:44
@wing328
Copy link
Member

wing328 commented Oct 28, 2019

cc @jimschubert (2017/09), @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04)

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, which looks good to me.

@wing328 wing328 merged commit a2b37d6 into OpenAPITools:master Oct 29, 2019
@wing328 wing328 changed the title Kotlin query collection format Fix Kotlin query collection format Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Kotlin Client] Incorrect pipes and csv query collection delimeter
2 participants