-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[cli][script] Fix misspelling in cli bootstrapping script #4356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
@RonnyPfannschmidt just an FYI |
This can be tested with:
Then, test with another version:
And repeat the validations to verify. |
@OpenAPITools/generator-core-team (since there's no technical committee for helper scripts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yikes, what an oversight on my side, thanks for catching and applying a roundabout solution
No problem... It happens! Sorry I wasn't able to review the original PR. I've been playing catch-up for a few months. |
@jimschubert what about adding it to the CI somehow? (assuming it's not a lot of work) |
@wing328 This script just calls maven to get the .jar and (now) supports two environment variables. I don't think there's anything beneficial to test on every build for this. Manual testing on PR merges should suffice. |
@jimschubert agreed. If it gains more activity/usage, we may consider adding a test to the CI later |
Fixes a misspelling in the cache directory environment variable introduced in #3631, warning users that they need to migrate to the properly spelled variable.
Also creates the directory if it doesn't exist.
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.1.x
,5.0.x
. Default:master
.