Typescript refactor: stub rxjs

[bodograumann]

As discussed in #802 I have replaced RxJS with a stub when it is not really needed.
There is a new option for the typescript generator useRxJS which defaults to false.

Additionally I fixed some minor issues.

I noticed that the tests in samples/client/petstore/typescript/tests are not automatically generated, but statically committed. So that is another open todo?

CC @TiFu

[TiFu]

Thanks for the PR!

Just a couple small questions:

Did you compile it locally and did it work? The issue below looks unrelated to your changes - I am wondering if that was an issue previously because I remember it being okay in your previous PR.

> [email protected] build /home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/typescript/builds/default

> tsc

http/http.ts(29,8): error TS2304: Cannot find name 'Buffer'.
http/http.ts(29,8): error TS4033: Property 'data' of exported interface has or is using private name 'Buffer'.

node_modules/form-data/index.d.ts(6,23): error TS2688: Cannot find type definition file for 'node'.
node_modules/form-data/index.d.ts(7,25): error TS2307: Cannot find module 'stream'.
node_modules/form-data/index.d.ts(8,23): error TS2307: Cannot find module 'http'.
node_modules/form-data/index.d.ts(28,16): error TS2304: Cannot find name 'Buffer'.

Also looks like there are uncommitted changes to the generator README (i.e. ensure-up-to-date.sh wasn't executed)

UNCOMMITTED CHANGES ERROR
There are uncommitted changes in working tree after execution of 'bin/ensure-up-to-date'
Perform git diff
diff --git a/docs/generators/typescript.md b/docs/generators/typescript.md
index e5d3540d8a..11ebf4ce29 100644
--- a/docs/generators/typescript.md
+++ b/docs/generators/typescript.md
@@ -12,4 +12,5 @@ sidebar_label: typescript
 |modelPropertyNaming|Naming convention for the property: 'camelCase', 'PascalCase', 'snake_case' and 'original', which keeps the original name| |camelCase|
 |supportsES6|Generate code that conforms to ES6.| |false|
 |fileContentDataType|Specifies the type to use for the content of a file - i.e. Blob (Browser) / Buffer (node)| |Buffer|
+|useRxJS|Enable this to internally use rxjs observables. If disabled, a stub is used instead. This is required for the 'angular' framework.| |false|
 |framework|Specify the framework which should be used in the client code.|<dl><dt>**fetch-api**</dt><dd>fetch-api</dd><dt>**jquery**</dt><dd>jquery</dd><dl>|fetch-api|
Perform git status
On branch pull/4424
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   docs/generators/typescript.md

no changes added to commit (use "git add" and/or "git commit -a")
Please run 'bin/utils/ensure-up-to-date' locally and commit changes (UNCOMMITTED CHANGES ERROR)

[TiFu]

Why was this changed to Promise?

[bodograumann]

Compilation errors

I compiled locally. The mvn and generating the samples worked fine.
The tests did not work. I am not sure why that is. It was indeed confusing because the last time it worked, but when I checked out the typescript-refactor branch and rebuild everything, they still would not work. I guess I need to take a little more time to investigate this issue.

Readme

Yeah, I did not run ensure-up-to-date.sh again. I was hoping it wasn't needed because last time it changed unrelated things differently than the CI.
Have added the docs line for the useRxJS switch manually now.

Middleware

I changed it to what I think the original intention was. This is the only way that makes sense to me. Previously both interfaces Middleware and PromiseMiddleware where identical.
When thinking about how middlewares should work with RxJS stubed, I came to the conclusion, that only PromiseMiddleware which is then wrapped, can be used. The user should not be aware of the Observable stub, so he must work only with Promise.

I updated the code comments to make everything a bit clearer, I hope.

[bodograumann]

Ok, got the tests to run on the original branch and found the problem:
We require the node types, but only implicitly depended on them via @types/form-data.
I have now added them as an explicit dependency.
Furthermore I have adjusted the dependencies in the tests according to the changes to the template and samples.

For the jquery tests to run I had to install webpack.

The tests where using Observable.subscribe. Afaics this is currently not really necessary, so I replaced it with the stubbed Observable.toPromise().then. If in the future it is needed, we can of course add it to the stub.

Not sure whether the jquery tests ran properly on my local machine, because I got

> node ./dist/test-runner.js

[error] Failed to load resource: the server responded with a status of 404 (Not Found)

But let's see what the ci says.

[bodograumann]

The failures don’t seem to be related to my changes.
What do you think, @TiFu?

[TiFu]

Thanks a lot for investigating this issue and the PR!

• CircleCI is unrelated
• DroneIO as well
  Going to close and reopen this PR to rerun the tests. If it fails again, i'll just merge anyway.

Compilation errors
Readme

Sounds good

Middleware

Oh the change was in PromiseMiddleware. Good catch.

[bodograumann]

Ok, forgot to remove subscribe from the jquery tests. Now it really is complete :-D
Tests seem good. Failure because of some OCAML stuff. Different from before but still unrelated to these changes.

[TiFu]

Great! Again, thanks for the PR which has been merged into ts-refactor.

[wing328]

@bodograumann thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800