Skip to content

[BUG][R] use loadNamespace instead of package:pkgName string #4614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2019
Merged

[BUG][R] use loadNamespace instead of package:pkgName string #4614

merged 2 commits into from
Nov 29, 2019

Conversation

LiNk-NY
Copy link
Contributor

@LiNk-NY LiNk-NY commented Nov 26, 2019

Hi William, @wing328

This change makes use of loadNamespace instead of package:{{packageName}}.
The latter requires that the package be attached to the search path when using
as.environment (this can cause issues when it is not). The current change loads
the namespace before its use.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc: @Ramanth @saigiridhar21

@auto-labeler
Copy link

auto-labeler bot commented Nov 26, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328
Copy link
Member

wing328 commented Nov 27, 2019

Looks good to me. If no one has further feedback, I'll merge it on the coming Friday.

@wing328 wing328 merged commit 18b950c into OpenAPITools:master Nov 29, 2019
@wing328 wing328 added this to the 4.2.2 milestone Dec 2, 2019
@wing328
Copy link
Member

wing328 commented Dec 2, 2019

@LiNk-NY thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants