-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[Go] Add multiple servers support to Go(-experimental) client #4635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b86bf7e
to
f06dd3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. There are couple minor things that I'd suggest fixing (see the review), but otherwise this is great start to support server variables.
Additionally, this is in line with what other languages (e.g. Python) use, so this is also ok in terms of consistency across the whole project.
modules/openapi-generator/src/main/resources/go-experimental/configuration.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/go/configuration.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/go-experimental/configuration.mustache
Show resolved
Hide resolved
5a82f5f
to
7576a31
Compare
@wing328 hey William 👋 . It seems that this PR is failing in CI because it uses Go 1.12 (released February 2019) feature ( Otherwise this PR LGTM, so once we clear the situation with |
Ah, please disregard my previous comment, I was looking wrong. This now uses |
7576a31
to
b8d0548
Compare
@bkabrda it seems that the PR description template is not completely acurate. $ find . -iname \*go-\*.sh | grep -v server
./bin/go-experimental-petstore.sh
./bin/openapi3/go-experimental-petstore.sh
./bin/openapi3/go-petstore.sh
./bin/go-petstore-withxml.sh # <- I was missing this one !!!
./bin/go-petstore.sh I wish there was a $ make samples
# or
$ make samples-go samples-go-experimental |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, LGTM now 👍
b8d0548
to
4f40b89
Compare
Allows the Go(-Experimental) API client to retrieve all server URLs defined in the spec
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.cc @antihax (2017/11) @bvwells (2017/12) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)
related PRs