[REQ][GO] add awsv4 signature support #4784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerome-jutteau
force-pushed
the
fix_issue4783
branch
2 times, most recently
from
eaa45cd to
ddecdcc
Compare
|
Auto-review: as I add a new authentication method, I would probably need to add some test at least in |
|
@jerome-jutteau thanks for the PR. I think this should be added via an option instead as not everyone needs the awsv4 signature support |
wing328
added
Client: Go
Enhancement: General
Enhancement: Feature
and removed
Enhancement: General
labels
OpenAPI format does not support AWS Signature method. This commit add support for AWSv4 signature in GO client generation by adding "withAWSV4Signature" option. "withAWSV4Signature" option is false by default. Signed-off-by: Jérome Jutteau <[email protected]>
Signed-off-by: Jérome Jutteau <[email protected]>
jerome-jutteau
force-pushed
the
fix_issue4783
branch
from
ddecdcc to
17cbe8d
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Adding support for AWSv4 signature in golang (see #4783).
./bin/go-petstore.shok./bin/openapi3/go-petstore.shokdocker build .okNewcomer here, feedback is welcome :)
copy @antihax @bvwells @grokify @kemokemo @bkabrda
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.