Skip to content

add multipleOf to CodegenProperty (#2192) #5009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

yasammez
Copy link
Contributor

This includes the missing property mapping from #2192. I testet the codegen with a custom template and it worked. But since this is my first PR in this repo, please review carefully if I managed to adhere to all standards and tell me if something is missing.

PR checklist

  • Read the contribution guidelines.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.

@wing328
Copy link
Member

wing328 commented Jan 16, 2020

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328 wing328 added this to the 4.2.3 milestone Jan 16, 2020
@yasammez
Copy link
Contributor Author

Thank you for noticing. Should be fixed now :-)

@wing328
Copy link
Member

wing328 commented Jan 16, 2020

The CircleCI failure is not related to this PR.

@wing328 wing328 merged commit b94fe7a into OpenAPITools:master Jan 16, 2020
@wing328
Copy link
Member

wing328 commented Jan 17, 2020

I've filed #5021 to add multipleOf to various Codegen classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants