Skip to content

[csharp-netcore] Update RestSharp and improve async methods #5066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 26, 2020
Merged

[csharp-netcore] Update RestSharp and improve async methods #5066

merged 6 commits into from
Jan 26, 2020

Conversation

shibayan
Copy link
Contributor

Update RestSharp and streamline execution of task-based asynchronous methods. Removed deprecated blocking code for synchronous methods.

This PR close #3066

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@etherealjoy
Copy link
Contributor

etherealjoy commented Jan 21, 2020

@shibayan
Thanks for fixing the issue, I assume this warning is also removed right? It was not originally listed in #3066

ApiClient.cs(412,34,412,65): warning CS0618: 'RestClient.ExecuteTaskAsync<T>(IRestRequest)' 
is obsolete: 'Please use ExecuteAsync instead'

@shibayan
Copy link
Contributor Author

@etherealjoy
Yes. At the same time, ExecuteTaskAsync<T> => ExecuteAsync<T> was replaced.

@jimschubert jimschubert modified the milestones: 4.2.3, 4.3.0 Jan 23, 2020
@jimschubert jimschubert merged commit 305b727 into OpenAPITools:master Jan 26, 2020
@jimschubert jimschubert modified the milestones: 4.3.0, 4.2.3 Jan 26, 2020
@shibayan shibayan deleted the update-csharp-netcore branch February 2, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [csharp-netcore] Obsolete method warning
4 participants