[r] Handling CRAN feedback for example snippets #5345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
saigiridhar21
changed the title
saigiridhar21
force-pushed
the
fix/r/cran-feedback
branch
from
da325ad to
350b656
Compare
saigiridhar21
force-pushed
the
fix/r/cran-feedback
branch
from
350b656 to
b83d5d3
Compare
Do you have the URL to the recommendation for our reference? |
CRAN shares feedback through email and so there is no recommendation link. |
|
@saigiridhar21 that's ok. I'm ok with this change. |
MikailBag
pushed a commit
to MikailBag/openapi-generator
that referenced
this pull request
Mar 23, 2020
* fix(r): Updating donttest to dontrun * fix(r): Updating donttest to dontrun
|
@saigiridhar21 thanks for the PR, which has been included in the 4.3.0 release: https://twitter.com/oas_generator/status/1243455743937789952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRAN committee recommended using
dontruninstead ofdonttest. The reason is that the generated OpenAPI client library uses some sort of authentication anddontrunspecifies that the example snippets can't be run without defining some additional configuration like API keys/username-password etc. whereasdonttestspecifies that examples can be run without any additional configurations manually.PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@Ramanth