always use @JacksonXmlElementWrapper and read xml data from reference…

[jzrebiec]

Hello All,

This pull request adds:

• always writes JacksonXmlElementWrapper even if xml.wrapped is false, because useWrapping is true from Jackson 2.1
• get xml properties from referenced schema.

Here is example of yaml:

openapi: 3.0.0
info:
  title: API
  version: 1.0.0

paths:
  /:
    post:
      requestBody:
        required: true
        content:
          application/xml:
            schema:
              $ref: '#/components/schemas/Request'
      responses:
        '200':
          description: OK

components:
  schemas:
    Request:
      type: object
      properties:
        simpleAttribute:
          type: string
          xml:
            attribute: true
            name: ATTR
        refAttribute:
          $ref: '#/components/schemas/RefAttribute'
        simpleNode:
          type: object
          properties:
            prop1:
              type: string
            prop2:
              type: string
          xml:
            name: NODE
        refNode:
          $ref: '#/components/schemas/RefNode'
        simpleArray:
          type: array
          items:
            type: string
            xml:
              name: ARR_ITEM
        simpleWrappedArray:
          type: array
          items:
            type: string
            xml:
              name: ARR_ITEM
          xml:
            wrapped: true
            name: WRAPPED_ARRAY
        nodeArray:
          type: array
          items:
            $ref: '#/components/schemas/RefNode'
        wrappedNodeArray:
          type: array
          items:
            $ref: '#/components/schemas/RefNode'
          xml:
            wrapped: true
            name: WRAPPED_NODE_ARRAY
      xml:
        name: Request

    RefAttribute:
      type: string
      enum: [A, B, C]
      xml:
        name: REF_ATTR
        attribute: true

    RefNode:
      type: object
      properties:
        prop1:
          type: string
        prop2:
          type: string
      xml:
        name: REF_NODE

   

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
  @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

[jzrebiec]

Hello,

Can anyone look into this?

[RockyMM]

@jzrebiec Czesc, can you resolve conflicts? I will try to get the attention of project maintainers. Thanks!

[jzrebiec]

@RockyMM Hi, I have just rebased the branch

[commievid]

Would definitely like this to be in soon, we had some head scratching around the XML and Spring!

[RockyMM]

Ah, life... Too much time spent on too many things :D

I am terribly sorry @jzrebiec , would you mind rebasing your commits again? :D

[jzrebiec]

@RockyMM Unfortunately, I changed a project, so I don't need the changes anymore. If You want (and have time), feel free to take over the PR.

[scholzi100]

PR looks good, used it in a project. @RockyMM @jzrebiec looks like PR needs to be rebased and it needs to get some attention from openapi-generator.

[mutyasaisrikar]

@scholzi100 @RockyMM @jzrebiec, It would be very helpful if we can merge these changes.

[rkurucz9]

I would be grateful if these helpful changes could be merged.

[RockyMM]

I might have some capacity in December to check this issue. Don't hold your hopes too high though 😅

[Philzen]

As the relevant changes to DefaultCodegen.java from this PR were merged via #15115, closing this PR for now.