Minor improvements to the Lua client generator #6219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
changed the title
daurnimator
reviewed
May 9, 2020
| @@ -60,6 +60,10 @@ function pet_api:add_pet(pet) | |||
| --local var_content_type = { "application/json", "application/xml" } | |||
| req.headers:upsert("accept", "application/json") | |||
|
|
|||
| -- TODO: create a function to select proper content-type | |||
| --local var_accept = { "application/xml", "application/json" } | |||
| req.headers:upsert("content-type", "application/xml") | |||
There was a problem hiding this comment.
You're setting the content type to xml, but sending json.
There was a problem hiding this comment.
Right it's a known issue as mentioned in the code comment.
-- TODO: create a function to select proper content-type
As a workaround, users can rearrange the accepts to have application/json placed in the front.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.cc @daurnimator