-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[Java][jersey2] replace jersey2 with jersey2-experimental #6251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Travis CI failure not related to this PR. |
Why did you replace something stable with experimental stuff? Does that mean that now I shouldn't upgrade from 4.2 to 4.3 because this is experimental? |
The main difference is oneOf implementation. Give it a try to see if it works better in your use case. |
mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); | ||
mapper.configure(DeserializationFeature.FAIL_ON_INVALID_SUBTYPE, false); | ||
mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, true); | ||
mapper.configure(DeserializationFeature.FAIL_ON_INVALID_SUBTYPE, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wing328 is there a way to toggle these back to false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wasted two hours on debugging after updating the OpenApiTools gradle plugin. This is a very breaking change and it was not mentioned by the changelog or release notes. This is also not in line with most of the other generator-libraries and there is no explanation for this change. Why was this changed silently?
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)