Skip to content

[Java][jersey2] replace jersey2 with jersey2-experimental #6251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 12, 2020

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 11, 2020

  • replace jersey2 with jersey2-experimental, which has better support for oneOf, anyOf.
  • minor fix to ApiClient when the spec doesn't use OAuth authentication

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

@wing328 wing328 requested a review from jimschubert as a code owner May 11, 2020 16:25
@wing328
Copy link
Member Author

wing328 commented May 12, 2020

Travis CI failure not related to this PR.

@wing328 wing328 merged commit deec5da into master May 12, 2020
@wing328 wing328 deleted the jersey2-exp-prod branch May 12, 2020 10:27
@40rn05lyv
Copy link

Why did you replace something stable with experimental stuff? Does that mean that now I shouldn't upgrade from 4.2 to 4.3 because this is experimental?

@40rn05lyv
Copy link

@wing328

@wing328
Copy link
Member Author

wing328 commented Jul 8, 2020

experimental is just a word. We could name it something else (e.g. jersey2-next-generation).

The main difference is oneOf implementation. Give it a try to see if it works better in your use case.

Comment on lines -30 to +31
mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
mapper.configure(DeserializationFeature.FAIL_ON_INVALID_SUBTYPE, false);
mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, true);
mapper.configure(DeserializationFeature.FAIL_ON_INVALID_SUBTYPE, true);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wing328 is there a way to toggle these back to false?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wasted two hours on debugging after updating the OpenApiTools gradle plugin. This is a very breaking change and it was not mentioned by the changelog or release notes. This is also not in line with most of the other generator-libraries and there is no explanation for this change. Why was this changed silently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants