[docker] Tag latest-release for stable latest tagging #6573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
jimschubert
commented
Jun 6, 2020
| commit-ish: 'HEAD~' | ||
|
|
||
| - name: DockerHub Login | ||
| run: echo "${{ secrets.DOCKER_PASSWORD }}" | docker login -u "${{ secrets.DOCKER_USERNAME }}" --password-stdin |
There was a problem hiding this comment.
note to reviewer, I'd recommend trying a similar command here in a private repo to become familiar with it. This follows GitHub Workflow documentation by passing creds into supported stdin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
latesttags track master. We don't currently have a stable tracking tag.This github workflow runs every couple of days, gets the last known tagged release from git metadata, pulls that image from dockerhub if it exists, and creates/updates a tag which represents the latest release.
openapitools/openapi-generator-online:latest-releaseopenapitools/openapi-generator:cli-latest-releaseopenapitools/openapi-generator:online-latest-releaseReview github workflow docs for details on secrets usage.
Secrets are already setup and ready for this to be merged.
fixes #3840
cc @OpenAPITools/generator-core-team
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.