-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Fix default response #6625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default response #6625
Conversation
@wing328 21 hours for review, really? 😄 openapi-generator/modules/openapi-generator/src/main/resources/php-slim4-server/SlimRouter.mustache Line 76 in 8689625
|
Now build does compile, don't know why it didn't work. There are changes in Slim4 samples folder like: $ git diff samples/server/petstore/php-slim4/lib/SlimRouter.php
diff --git a/samples/server/petstore/php-slim4/lib/SlimRouter.php b/samples/server/petstore/php-slim4/lib/SlimRouter.php
index 4588e17fd5..6052fa0b97 100644
--- a/samples/server/petstore/php-slim4/lib/SlimRouter.php
+++ b/samples/server/petstore/php-slim4/lib/SlimRouter.php
@@ -61,7 +61,7 @@ class SlimRouter
'userClassname' => 'AnotherFakeApi',
'operationId' => 'call123TestSpecialTags',
'responses' => [
- 'default' => [
+ '200' => [
'code' => 200,
'message' => 'successful operation',
'jsonSchema' => '{ |
@ybelenko There was an issue with So the Slim router must have the |
Not really, but it helpfull for Mock feature. |
Fix
isDefault
mustache tag in the responsewhich impacts the following generators and I've updated the template accordingly:
cc @OpenAPITools/generator-core-team
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*
. For Windows users, please run the script in Git BASH.master