Skip to content

Fix default response #6625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 12, 2020
Merged

Fix default response #6625

merged 8 commits into from
Jun 12, 2020

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jun 11, 2020

Fix isDefault mustache tag in the response

which impacts the following generators and I've updated the template accordingly:

cc @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 added the WIP Work in Progress label Jun 11, 2020
@wing328 wing328 merged commit 8689625 into master Jun 12, 2020
@wing328 wing328 deleted the fix_default_response branch June 12, 2020 07:51
@ybelenko
Copy link
Contributor

ybelenko commented Jun 12, 2020

@wing328 21 hours for review, really? 😄
I guess you didn't update php-slim4 samples because I use {{#isDefault}} in

'{{#isDefault}}default{{/isDefault}}{{^isDefault}}{{code}}{{/isDefault}}' => [

@ybelenko
Copy link
Contributor

Now build does compile, don't know why it didn't work. There are changes in Slim4 samples folder like:

$  git diff samples/server/petstore/php-slim4/lib/SlimRouter.php
diff --git a/samples/server/petstore/php-slim4/lib/SlimRouter.php b/samples/server/petstore/php-slim4/lib/SlimRouter.php
index 4588e17fd5..6052fa0b97 100644
--- a/samples/server/petstore/php-slim4/lib/SlimRouter.php
+++ b/samples/server/petstore/php-slim4/lib/SlimRouter.php
@@ -61,7 +61,7 @@ class SlimRouter
             'userClassname' => 'AnotherFakeApi',
             'operationId' => 'call123TestSpecialTags',
             'responses' => [
-                'default' => [
+                '200' => [
                     'code' => 200,
                     'message' => 'successful operation',
                     'jsonSchema' => '{

@wing328
Copy link
Member Author

wing328 commented Jun 12, 2020

@ybelenko There was an issue with isDefault which is fixed by this PR. Another PR is pending this one so sorry for the short notice.

So the Slim router must have the default specified in order to work?

@wing328 wing328 added this to the 5.0.0 milestone Jun 12, 2020
@ybelenko
Copy link
Contributor

So the Slim router must have the default specified in order to work?

Not really, but it helpfull for Mock feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants