-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[C++] [restsdk]Update CMakeLists.txt for seamless building on Windows and Linux #6658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
etherealjoy
merged 4 commits into
OpenAPITools:master
from
etherealjoy:cpprestsdk-cmake-update
Jun 15, 2020
Merged
[C++] [restsdk]Update CMakeLists.txt for seamless building on Windows and Linux #6658
etherealjoy
merged 4 commits into
OpenAPITools:master
from
etherealjoy:cpprestsdk-cmake-update
Jun 15, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing the line ending
muttleyxd
suggested changes
Jun 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can make some changes, good changes though 😁
modules/openapi-generator/src/main/resources/cpp-rest-sdk-client/cmake-lists.mustache
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/cpp-rest-sdk-client/cmake-lists.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/cpp-rest-sdk-client/cmake-lists.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/cpp-rest-sdk-client/cmake-lists.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/cpp-rest-sdk-client/cmake-lists.mustache
Outdated
Show resolved
Hide resolved
muttleyxd
approved these changes
Jun 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
CMakeLists.txt
for easier building on Linux/Unix and Windows hosts.@stkrwork @MartinDelille @ravinikam @muttleyxd
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*
. For Windows users, please run the script in Git BASH.master