Skip to content

[php-ze-ph] Set required PHP version to ^7.2 #6763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2020

Conversation

ybelenko
Copy link
Contributor

  • Composer required PHP version set to ^7.2
  • Readme PHP version set to >=7.2
  • Input spec for samples generation changed to OAS3

It's weird that samples/server/petstore/php-ze-ph/src/App/ErrorMiddleware.php file has not been regenerated. This file isn't presented in generator templates folder modules/openapi-generator/src/main/resources/php-ze-ph.
Related #6522

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @renepardon
thanks to @Articus for help with testing

@ybelenko ybelenko force-pushed the 6522_phpze_server branch from 7ddde15 to 390dc8b Compare June 30, 2020 07:38
@wing328 wing328 merged commit 6224f5e into OpenAPITools:master Jul 1, 2020
@ybelenko ybelenko deleted the 6522_phpze_server branch July 1, 2020 07:53
jimschubert added a commit that referenced this pull request Jul 3, 2020
* master: (142 commits)
  update python samples
  clarify direction of py client side validation flag (#6850)
  fix erronous cmd arg example for docker in readme (#6846)
  [BUG] [JAVA] Fix multiple files upload (#4803) (#6808)
  [kotlin][client] fix retrofit dependencies (#6836)
  [PowerShell] add more fields to be customized (#6835)
  [Java][WebClient]remove the dead code from java ApiClient.mustache (#6556)
  [PHP] Better handling of invalid data (array) (#6760)
  Make ApiClient in retrofit2 be able to use own OkHttpClient (#6699)
  mark python2 support in flask as deprecated (#6653)
  update samples
  [Java][jersey2] Add a getter for the User-Agent header value (#6831)
  Provides a default nil value for optional init parameters (#6827)
  [Java] Deprecate feignVersion option (#6824)
  [R] Enum R6Class Support, closes #3367 (#5728)
  [Rust][Client] Unify sync/async client structure (#6753)
  [php-ze-ph] Set required PHP version to ^7.2 (#6763)
  [Java][client][native][Gradle] Add missing jackson-databind-nullable (#6802)
  Improve sttpOpenApiClient generator (#6684)
  Update docker-tag-latest-release.yml
  ...
@ybelenko
Copy link
Contributor Author

ybelenko commented Aug 9, 2020

I would like to ask a review from authors of Zend Expressive via Github issues, but I can't find current main repo.
@Articus I guess you know this framework better, can you help me a bit? Was it renamed to Laminas? If so why it's suggest to use mezzio/mezzio package as substitution?

@Articus
Copy link
Contributor

Articus commented Aug 9, 2020

You are correct - Laminas project is a new name for all packages previously known as parts of Zend Framework. Here is full list of renamed organizations for packages. I am not sure about exact reasoning behind those renames though. They could use Laminas Expressive, but ended up with new name Mezzio instead.

@weierophinney
Copy link

@Articus and @ybelenko

The equivalent to Zend Expressive is indeed Mezzio. The reason for the renames:

  • We transferred Zend Framework to the Linux Foundation. Since the company Zend still exists, the project as a whole needed a rename.
  • Apigility and Expressive had existing trademarks, and the logistics and costs of transferring those were quite onerous for all parties. As such, those subprojects needed to be renamed as well. We chose to rename Apigility to Laminas API Tools as we didn't want to register a unique name for it when its future is a bit uncertain (due to the move to do API tooling within Expressive/Mezzio). We chose Mezzio as the new name for Expressive as it (a) is a word that does not exist in any other language, (b) has an affinity to the Italian "Mezzo", which in turn (c) has a meaning of "middle" or "between", which is reminiscent of Middleware.

I'd be happy to help in updating the php-ze-ph generator to Mezzio; could somebody point me to the relevant areas of code?

@Articus
Copy link
Contributor

Articus commented Oct 31, 2020

@weierophinney, nice to see you here!
The situation with migration to Mezzio is a bit tricky, its summary is in this issue.

The hardest step is complete - latest versions of DataTransfer and PathHandler are using Laminas packages. And for last two weeks I was slowly updating php-ze-ph generator itself.

could somebody point me to the relevant areas of code?

The main bits are generator class and generator templates. You may also want to check a sample of generated code. It is quite different from standard Zend Expressive/Mezzio skeleton. Your review will be greatly appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants