-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[php-ze-ph] Set required PHP version to ^7.2 #6763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7adab12
to
7ddde15
Compare
7ddde15
to
390dc8b
Compare
* master: (142 commits) update python samples clarify direction of py client side validation flag (#6850) fix erronous cmd arg example for docker in readme (#6846) [BUG] [JAVA] Fix multiple files upload (#4803) (#6808) [kotlin][client] fix retrofit dependencies (#6836) [PowerShell] add more fields to be customized (#6835) [Java][WebClient]remove the dead code from java ApiClient.mustache (#6556) [PHP] Better handling of invalid data (array) (#6760) Make ApiClient in retrofit2 be able to use own OkHttpClient (#6699) mark python2 support in flask as deprecated (#6653) update samples [Java][jersey2] Add a getter for the User-Agent header value (#6831) Provides a default nil value for optional init parameters (#6827) [Java] Deprecate feignVersion option (#6824) [R] Enum R6Class Support, closes #3367 (#5728) [Rust][Client] Unify sync/async client structure (#6753) [php-ze-ph] Set required PHP version to ^7.2 (#6763) [Java][client][native][Gradle] Add missing jackson-databind-nullable (#6802) Improve sttpOpenApiClient generator (#6684) Update docker-tag-latest-release.yml ...
I would like to ask a review from authors of Zend Expressive via Github issues, but I can't find current main repo. |
You are correct - Laminas project is a new name for all packages previously known as parts of Zend Framework. Here is full list of renamed organizations for packages. I am not sure about exact reasoning behind those renames though. They could use Laminas Expressive, but ended up with new name Mezzio instead. |
The equivalent to Zend Expressive is indeed Mezzio. The reason for the renames:
I'd be happy to help in updating the php-ze-ph generator to Mezzio; could somebody point me to the relevant areas of code? |
@weierophinney, nice to see you here! The hardest step is complete - latest versions of DataTransfer and PathHandler are using Laminas packages. And for last two weeks I was slowly updating
The main bits are generator class and generator templates. You may also want to check a sample of generated code. It is quite different from standard Zend Expressive/Mezzio skeleton. Your review will be greatly appreciated :) |
It's weird that
samples/server/petstore/php-ze-ph/src/App/ErrorMiddleware.php
file has not been regenerated. This file isn't presented in generator templates foldermodules/openapi-generator/src/main/resources/php-ze-ph
.Related #6522
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*
. For Windows users, please run the script in Git BASH.master
cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @renepardon
thanks to @Articus for help with testing