[SWIFT5] Add the ability to turn uniqueItems array into Set in swift. #6773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[SWIFT5] Add Ability to use isSet when Array is uniqueItems
|
Looks good to me. |
|
Thanks @4brunu. I'm not seeing a |
|
You are right, with version |
wing328
reviewed
Jun 26, 2020
| @@ -634,12 +634,12 @@ public String toDefaultValue(Schema p) { | |||
|
|
|||
| @Override | |||
| public String toInstantiationType(Schema p) { | |||
| if (ModelUtils.isMapSchema(p)) { | |||
| if (ModelUtils.isMapSchema(p)) { | |||
There was a problem hiding this comment.
Will fix the code indentation with 4-space instead of tabs in a separate commit:
update: 5cce9dc
|
Travis CI failure already fixed in the master. |
6 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to turn uniqueItems array into Set in swift.
CC Swift5 technical committee @jgavris (@ehyche @Edubits @jaz-ah @4brunu