[Go-client] Fix inability to download files #9714
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the way pass-by-value and pass-by-reference variables are used. Closes OpenAPITools#8489
If polymorphism without discriminator was used, the previous code was unable to properly decode the vaules. By using a strict decoder, which rejects unknown fields, type guessing now works.
the ability to download files. This reverts the change from OpenAPITools@14d4131
wing328
reviewed
Jun 15, 2021
| @@ -419,6 +419,15 @@ func (c *APIClient) decode(v interface{}, b []byte, contentType string) (err err | |||
| *s = string(b) | |||
| return nil | |||
| } | |||
| if f, ok := v.(**os.File); ok { | |||
| *f, err = ioutil.TempFile("", "HttpClientFile") | |||
There was a problem hiding this comment.
I got the following errors when testing the petstore go client:
go-petstore/client.go:391:13: undefined: ioutil
Can you please take a look when you've time?
There was a problem hiding this comment.
Sorry about that. That is my mistake for missing that as my dev environment will do auto-imports that hid this.
There was a problem hiding this comment.
Looks like you merge another PR into your PR.
Can you file a PR with just the fix for downloading the files?
5 tasks
|
I've cherry-pick your commits and filed #9812 instead. Closing this one. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert a change to the Go Client code that broke the ability to download files. This reverts the change made during the switch go-experimental
from 14d4131
Fix for #8039
The decoding for type
filehad been removed when the generator was switched togo-experimentalRe-added the code that existed in the 4.x release to handle downloading a file.
Tested by generating the pet-store examples to ensure that the previous code for downloading a file was present.
Generated an internal Go Rest API client that downloads a file from a Rest API. Then downloaded a file successfully.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d